Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: webkit/glue/resource_fetcher.cc

Issue 12218057: Disable cookies when fetching favicon. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_fetcher.cc
diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc
index c3d7c84eca2be4f1e9605b87c0353b2d1d88bd41..8729aa74369316e95213b791dae7ae4f5e909f7b 100644
--- a/webkit/glue/resource_fetcher.cc
+++ b/webkit/glue/resource_fetcher.cc
@@ -51,6 +51,10 @@ void ResourceFetcher::Cancel() {
void ResourceFetcher::Start(WebFrame* frame) {
WebURLRequest request(url_);
request.setTargetType(target_type_);
+ if (target_type_ == WebURLRequest::TargetIsFavicon) {
+ // Disable cookies to avoid side effects when fetching favicon.
+ request.setAllowCookies(false);
+ }
request.setFirstPartyForCookies(frame->document().firstPartyForCookies());
frame->dispatchWillSendRequest(request);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698