Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 12218018: Fix --gtest_output=xml: support. (Closed)

Created:
7 years, 10 months ago by M-A Ruel
Modified:
7 years, 10 months ago
Reviewers:
csharp
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/swarm_client.git@master
Visibility:
Public.

Description

Fix --gtest_output=xml: support. Google-test requires directory to be specified with a trailing /. Updated the smoke test to check more strictly the value passed as a regression test. Tested manually on Linux and Windows with base_unittests. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=180788

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M run_test_cases.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/gtest_fake/gtest_fake_xml.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
7 years, 10 months ago (2013-02-05 21:08:25 UTC) #1
csharp
lgtm
7 years, 10 months ago (2013-02-05 21:26:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12218018/3001
7 years, 10 months ago (2013-02-05 21:31:23 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 21:32:05 UTC) #4
Message was sent while issue was closed.
Change committed as 180788

Powered by Google App Engine
This is Rietveld 408576698