Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: tests/gtest_fake/gtest_fake_xml.py

Issue 12218018: Fix --gtest_output=xml: support. (Closed) Base URL: https://git.chromium.org/chromium/tools/swarm_client.git@master
Patch Set: typo Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « run_test_cases.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gtest_fake/gtest_fake_xml.py
diff --git a/tests/gtest_fake/gtest_fake_xml.py b/tests/gtest_fake/gtest_fake_xml.py
index 9fed63eda05cbdba54df0645421657cc185154ee..c0379d989e01d93d42ae02d70a0a3e530abb65e8 100755
--- a/tests/gtest_fake/gtest_fake_xml.py
+++ b/tests/gtest_fake/gtest_fake_xml.py
@@ -120,8 +120,11 @@ def main():
parser.error('Failed to process args %s' % args)
if options.gtest_output:
if not options.gtest_output.startswith('xml:'):
- parser.error('--gtest_output value must start with xm:')
+ parser.error('--gtest_output value must start with xml:')
options.gtest_output = options.gtest_output[len('xml:'):]
+ if (not os.path.isabs(options.gtest_output) or
+ not options.gtest_output[-1] == os.path.sep):
+ parser.error('Require strict absolute path ending with %s' % os.path.sep)
if options.trim_xml:
trim_xml()
« no previous file with comments | « run_test_cases.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698