Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 12218013: Fixing some indexed_db tests. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Anton Muhin, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing some indexed_db tests. These were broken by the webkit IDL roll, I was able to fix 2 of them but am still trying to figure out what broke on the final one (not sure it's related to the IDL roll). BUG=8341 Committed: https://code.google.com/p/dart/source/detail?r=18163

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-02-05 18:54:44 UTC) #1
sra1
lgtm
7 years, 10 months ago (2013-02-05 21:32:41 UTC) #2
Anton Muhin
7 years, 10 months ago (2013-02-06 11:47:55 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698