Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 12217071: Combine %_SubString and %_StringCharAt. (Closed)

Created:
7 years, 10 months ago by Yang
Modified:
7 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Combine %_SubString and %_StringCharAt. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -116 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M src/code-stubs.h View 3 chunks +27 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +15 lines, -17 lines 0 comments Download
M src/json.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp.js View 7 chunks +10 lines, -18 lines 0 comments Download
M src/runtime.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/string.js View 16 chunks +20 lines, -41 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 10 months ago (2013-02-07 17:22:11 UTC) #1
ulan
LGTM
7 years, 10 months ago (2013-02-13 14:44:34 UTC) #2
Yang
7 years, 10 months ago (2013-02-20 14:29:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698