src/runtime.cc - Issue 12217071: Combine %_SubString and %_StringCharAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 12217071: Combine %_SubString and %_StringCharAt. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index f808d1060cf4a4b7c00b5a6b47685742bcd76e6b..283a772331abf7106dde9fa3f6ace253639d2e6e 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -3547,6 +3547,10 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_SubString) {

RUNTIME_ASSERT(start >= 0);

RUNTIME_ASSERT(end <= value->length());

isolate->counters()->sub_string_runtime()->Increment();

+ if (end - start == 1) {

+ return isolate->heap()->LookupSingleCharacterStringFromCode(

+ value->Get(start));

+ }

return value->SubString(start, end);

}

« no previous file with comments | « src/regexp.js ('k') | src/string.js » ('j') | no next file with comments »