Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12212195: Re-land "view permission" feature (r179916) with Mac Fix. (Closed)

Created:
7 years, 10 months ago by Joe Thomas
Modified:
7 years, 10 months ago
Reviewers:
Finnur, sail, Matt Perry, sky
CC:
chromium-reviews, Aaron Boodman, tfarina, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-land "view permission" feature (r179916) with Mac Fix. The feature review URL: http://crrev.com/12094034 Mac fix review URL: http://crrev.com/12258023 This CL also combines the extension_install_prompt changes reviewed at http://crrev.com/12220142 RootCause for Mac failure: Permission Prompt does not have a OK button. And Chrome hangs while trying to create a OK button with empty string. Solution: Remove |okButton_| when its title is empty and adjust |cancelButton_|'s position. The screenshot with the fix is uploaded at http://crbug.com/175071#c15 BUG=170742, 175071 TBR=finnur@chromium.org TBR=sky@chromium.org for http://crrev.com/12094034 TBR=sail@chromium.org for http://crrev.com/12258023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182576

Patch Set 1 #

Patch Set 2 : Mac Fix Integrated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 9 chunks +36 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 1 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 1 2 chunks +24 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 1 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 5 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Joe Thomas
7 years, 10 months ago (2013-02-14 18:37:52 UTC) #1
Matt Perry
LGTM once you check in https://codereview.chromium.org/12258023
7 years, 10 months ago (2013-02-14 18:43:34 UTC) #2
Joe Thomas
On 2013/02/14 18:43:34, Matt Perry wrote: > LGTM once you check in https://codereview.chromium.org/12258023 The tests ...
7 years, 10 months ago (2013-02-14 18:44:59 UTC) #3
Matt Perry
Yeah, best to combine them.
7 years, 10 months ago (2013-02-14 18:45:58 UTC) #4
Joe Thomas
TBR=sky@chromium.org for http://crrev.com/12094034 TBR=sail@chromium.org for http://crrev.com/12258023 Matt, Could you please take another look at the ...
7 years, 10 months ago (2013-02-14 20:01:25 UTC) #5
Matt Perry
lgtm
7 years, 10 months ago (2013-02-14 20:11:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12212195/6001
7 years, 10 months ago (2013-02-14 20:15:20 UTC) #7
sail
cocoa/* LGTM
7 years, 10 months ago (2013-02-14 20:41:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12212195/6001
7 years, 10 months ago (2013-02-14 22:17:31 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 23:43:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 182576

Powered by Google App Engine
This is Rietveld 408576698