Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 12212195: Re-land "view permission" feature (r179916) with Mac Fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Fix Integrated Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 52f758beeeb7b53cb059f2655e4082206a2f049e..d2ab087c1f4e2ebc7d32e106c98343d294a09149 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -56,6 +56,7 @@ class ExtensionInstallPrompt
RE_ENABLE_PROMPT,
PERMISSIONS_PROMPT,
EXTERNAL_INSTALL_PROMPT,
+ POST_INSTALL_PERMISSIONS_PROMPT,
NUM_PROMPT_TYPES
};
@@ -81,6 +82,8 @@ class ExtensionInstallPrompt
// Getters for UI element labels.
string16 GetDialogTitle() const;
string16 GetHeading() const;
+ int GetDialogButtons() const;
+ bool HasAcceptButtonLabel() const;
string16 GetAcceptButtonLabel() const;
bool HasAbortButtonLabel() const;
string16 GetAbortButtonLabel() const;
@@ -280,6 +283,13 @@ class ExtensionInstallPrompt
const extensions::Extension* extension,
const IssueAdviceInfo& issue_advice);
+ // This is called by the app handler launcher to review what permissions the
+ // extension or app currently has.
+ //
+ // This *WILL* call Abort() on |delegate|.
+ virtual void ReviewPermissions(Delegate* delegate,
+ const extensions::Extension* extension);
+
// Installation was successful. This is declared virtual for testing.
virtual void OnInstallSuccess(const extensions::Extension* extension,
SkBitmap* icon);
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698