Issue 12212102: SPDY - Small bug fix for user after free. Will revert the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212102: SPDY - Small bug fix for user after free. Will revert the (Closed)

Created:
7 years, 10 months ago by ramant (doing other things)

Modified:
7 years, 10 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

SPDY - Small bug fix for user after free. Will revert the change asap. The change adds a scoped_refptr to SpdySession in DoLoop to clean up the state and to finish pending reads, in case SpdyFramer receives GOAway and closes all streams. DoReadComplete was holding the last reference before and DoLoop was accessing the object after DoReadComplete deleted the object at the end of the function. R=willchan@chromium.org BUG=175069 TEST=network unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181637

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	net/spdy/spdy_session.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12212102/1

7 years, 10 months ago (2013-02-09 22:45:10 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=82877

7 years, 10 months ago (2013-02-10 01:26:34 UTC) #4

commit-bot: I haz the power

7 years, 10 months ago (2013-02-10 01:37:34 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12212102/1

Expand Messages | Collapse Messages