Issue 12211139: Phase out BrowserList::empty() and BrowserList::size().

Issue 12211139: Phase out BrowserList::empty() and BrowserList::size(). (Closed)

Created:
7 years, 10 months ago by gab

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, sail+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Phase out BrowserList::empty() and BrowserList::size(). Replace last couple of instances by chrome::GetTotalBrowserCount() as in https://codereview.chromium.org/12212120/. oom_priority_manager.cc is ChromeOS only and thus only needs to care about the ash browser list. BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182378

Patch Set 1 : #

Patch Set 2 : merge up to r182211 #

Patch Set 3 : fix chromeos #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -29 lines)			Patch
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View	1 2	3 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser_list.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser_list.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download