Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc

Issue 12211139: Phase out BrowserList::empty() and BrowserList::size(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chromeos Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h" 5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
6 6
7 #include "ash/ash_switches.h" 7 #include "ash/ash_switches.h"
8 #include "ash/launcher/launcher.h" 8 #include "ash/launcher/launcher.h"
9 #include "ash/launcher/launcher_model.h" 9 #include "ash/launcher/launcher_model.h"
10 #include "ash/launcher/launcher_util.h" 10 #include "ash/launcher/launcher_util.h"
11 #include "ash/shell.h" 11 #include "ash/shell.h"
12 #include "ash/test/shell_test_api.h" 12 #include "ash/test/shell_test_api.h"
13 #include "ash/wm/window_util.h" 13 #include "ash/wm/window_util.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "base/utf_string_conversions.h" 15 #include "base/utf_string_conversions.h"
16 #include "chrome/browser/automation/automation_util.h" 16 #include "chrome/browser/automation/automation_util.h"
17 #include "chrome/browser/extensions/extension_apitest.h" 17 #include "chrome/browser/extensions/extension_apitest.h"
18 #include "chrome/browser/extensions/extension_browsertest.h" 18 #include "chrome/browser/extensions/extension_browsertest.h"
19 #include "chrome/browser/extensions/extension_function_test_utils.h" 19 #include "chrome/browser/extensions/extension_function_test_utils.h"
20 #include "chrome/browser/extensions/extension_service.h" 20 #include "chrome/browser/extensions/extension_service.h"
21 #include "chrome/browser/extensions/extension_system.h" 21 #include "chrome/browser/extensions/extension_system.h"
22 #include "chrome/browser/extensions/extension_test_message_listener.h" 22 #include "chrome/browser/extensions/extension_test_message_listener.h"
23 #include "chrome/browser/extensions/platform_app_browsertest_util.h" 23 #include "chrome/browser/extensions/platform_app_browsertest_util.h"
24 #include "chrome/browser/extensions/shell_window_registry.h" 24 #include "chrome/browser/extensions/shell_window_registry.h"
25 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h" 26 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h"
27 #include "chrome/browser/ui/browser.h" 27 #include "chrome/browser/ui/browser.h"
28 #include "chrome/browser/ui/browser_commands.h" 28 #include "chrome/browser/ui/browser_commands.h"
29 #include "chrome/browser/ui/browser_list.h" 29 #include "chrome/browser/ui/browser_finder.h"
30 #include "chrome/browser/ui/browser_window.h" 30 #include "chrome/browser/ui/browser_window.h"
31 #include "chrome/browser/ui/extensions/application_launch.h" 31 #include "chrome/browser/ui/extensions/application_launch.h"
32 #include "chrome/browser/ui/extensions/shell_window.h" 32 #include "chrome/browser/ui/extensions/shell_window.h"
33 #include "chrome/browser/ui/tabs/tab_strip_model.h" 33 #include "chrome/browser/ui/tabs/tab_strip_model.h"
34 #include "chrome/common/chrome_notification_types.h" 34 #include "chrome/common/chrome_notification_types.h"
35 #include "chrome/common/chrome_switches.h" 35 #include "chrome/common/chrome_switches.h"
36 #include "chrome/common/extensions/extension_constants.h" 36 #include "chrome/common/extensions/extension_constants.h"
37 #include "chrome/test/base/ui_test_utils.h" 37 #include "chrome/test/base/ui_test_utils.h"
38 #include "content/public/browser/notification_service.h" 38 #include "content/public/browser/notification_service.h"
39 #include "content/public/browser/notification_source.h" 39 #include "content/public/browser/notification_source.h"
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
864 tab_strip->CloseWebContentsAt(1, TabStripModel::CLOSE_NONE); 864 tab_strip->CloseWebContentsAt(1, TabStripModel::CLOSE_NONE);
865 // The status should now be set to closed. 865 // The status should now be set to closed.
866 EXPECT_EQ(ash::STATUS_CLOSED, model_->ItemByID(shortcut_id)->status); 866 EXPECT_EQ(ash::STATUS_CLOSED, model_->ItemByID(shortcut_id)->status);
867 } 867 }
868 868
869 // Checks that a windowed application does not add an item to the browser list. 869 // Checks that a windowed application does not add an item to the browser list.
870 IN_PROC_BROWSER_TEST_F(LauncherPerAppAppBrowserTestNoDefaultBrowser, 870 IN_PROC_BROWSER_TEST_F(LauncherPerAppAppBrowserTestNoDefaultBrowser,
871 WindowedAppDoesNotAddToBrowser) { 871 WindowedAppDoesNotAddToBrowser) {
872 // Get the number of items in the browser menu. 872 // Get the number of items in the browser menu.
873 size_t items = NumberOfDetectedLauncherBrowsers(); 873 size_t items = NumberOfDetectedLauncherBrowsers();
874 size_t running_browser = BrowserList::size(); 874 size_t running_browser = chrome::GetTotalBrowserCount();
875 EXPECT_EQ(0u, items); 875 EXPECT_EQ(0u, items);
876 EXPECT_EQ(0u, running_browser); 876 EXPECT_EQ(0u, running_browser);
877 877
878 LoadAndLaunchExtension("app1", extension_misc::LAUNCH_WINDOW, NEW_WINDOW); 878 LoadAndLaunchExtension("app1", extension_misc::LAUNCH_WINDOW, NEW_WINDOW);
879 879
880 // No new browser should get detected, even though one more is running. 880 // No new browser should get detected, even though one more is running.
881 EXPECT_EQ(0u, NumberOfDetectedLauncherBrowsers()); 881 EXPECT_EQ(0u, NumberOfDetectedLauncherBrowsers());
882 EXPECT_EQ(++running_browser, BrowserList::size()); 882 EXPECT_EQ(++running_browser, chrome::GetTotalBrowserCount());
883 883
884 LoadAndLaunchExtension("app1", extension_misc::LAUNCH_TAB, NEW_WINDOW); 884 LoadAndLaunchExtension("app1", extension_misc::LAUNCH_TAB, NEW_WINDOW);
885 885
886 // A new browser should get detected and one more should be running. 886 // A new browser should get detected and one more should be running.
887 EXPECT_GE(NumberOfDetectedLauncherBrowsers(), 1u); 887 EXPECT_GE(NumberOfDetectedLauncherBrowsers(), 1u);
888 EXPECT_EQ(++running_browser, BrowserList::size()); 888 EXPECT_EQ(++running_browser, chrome::GetTotalBrowserCount());
889 } 889 }
890 890
891 891
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/memory/oom_priority_manager.cc ('k') | chrome/browser/ui/browser_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698