Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/icon_manager_linux.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix presubmit. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/icon_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/icon_manager_linux.cc
diff --git a/chrome/browser/icon_manager_linux.cc b/chrome/browser/icon_manager_linux.cc
deleted file mode 100644
index 5dfa1554fb5bb21b1e56f5dbd61c98374372c151..0000000000000000000000000000000000000000
--- a/chrome/browser/icon_manager_linux.cc
+++ /dev/null
@@ -1,20 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/icon_manager.h"
-
-#include "base/nix/mime_util_xdg.h"
-#include "base/threading/thread_restrictions.h"
-
-IconGroupID IconManager::GetGroupIDFromFilepath(
- const base::FilePath& filepath) {
- // It turns out the call to base::nix::GetFileMimeType below does IO, but
- // callers of GetGroupIDFromFilepath assume it does not do IO (the Windows
- // and Mac implementations do not). We should fix this by either not doing IO
- // in this method, or reworking callers to avoid calling it on the UI thread.
- // See crbug.com/72740.
- base::ThreadRestrictions::ScopedAllowIO allow_io;
-
- return base::nix::GetFileMimeType(filepath);
-}
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/icon_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698