Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/icon_manager_linux.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix presubmit. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/icon_manager_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/icon_manager.h"
6
7 #include "base/nix/mime_util_xdg.h"
8 #include "base/threading/thread_restrictions.h"
9
10 IconGroupID IconManager::GetGroupIDFromFilepath(
11 const base::FilePath& filepath) {
12 // It turns out the call to base::nix::GetFileMimeType below does IO, but
13 // callers of GetGroupIDFromFilepath assume it does not do IO (the Windows
14 // and Mac implementations do not). We should fix this by either not doing IO
15 // in this method, or reworking callers to avoid calling it on the UI thread.
16 // See crbug.com/72740.
17 base::ThreadRestrictions::ScopedAllowIO allow_io;
18
19 return base::nix::GetFileMimeType(filepath);
20 }
OLDNEW
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/icon_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698