Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 12209042: Ensure syscall functions are consistently prefixed with "NaClSys" (Closed)

Created:
7 years, 10 months ago by Mark Seaborn
Modified:
7 years, 10 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Ensure syscall functions are consistently prefixed with "NaClSys" Rename NaClTextSysDyncode*() to NaClSysDyncode*() to match the syscall names. Rename NaClSetBreak() to NaClSysBrk(). Rename the syscall from "sysbrk" to "brk" so that the TCB function doesn't have to be called NaClSysSysBrk(), which would be odd. "brk" is at least consistent with Linux's syscall of the same name. BUG=none TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -60 lines) Patch
M src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/arch/mips/nacl_text_pad_test.S View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/arch/x86_32/nacl_text_pad_test.S View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/arch/x86_64/nacl_text_pad_test.S View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/include/bits/nacl_syscalls.h View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 3 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_handlers_gen.py View 3 chunks +12 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/nacl_text.h View 1 chunk +13 lines, -13 lines 0 comments Download
M src/trusted/service_runtime/nacl_text.c View 13 chunks +21 lines, -23 lines 0 comments Download
M src/untrusted/irt/irt_malloc.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/untrusted/irt/irt_memory.c View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/nacl/sbrk_private.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/untrusted/nacl/sysbrk.c View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/nacl/syscall_bindings_trampoline.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
7 years, 10 months ago (2013-02-06 18:23:07 UTC) #1
bradn
7 years, 10 months ago (2013-02-07 01:07:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698