Ensure syscall functions are consistently prefixed with "NaClSys"

src/trusted/service_runtime/nacl_syscall_handlers_gen.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 #  This script produces wrapped versions of syscall implementation
 #  functions.  The wrappers extract syscall arguments from where the
 #  syscall trampoline saves them.
 #
 #  Note that NaCl modules are always ILP32 and compiled with a
@@ skipping 99 matching lines @@
     ('NACL_sys_lseek', 'NaClSysLseek',
      ['int d', 'nacl_abi_off_t *offp', 'int whence']),
     ('NACL_sys_ioctl', 'NaClSysIoctl',
      ['int d', 'int request', 'void *arg']),
     ('NACL_sys_fstat', 'NaClSysFstat',
      ['int d', 'struct nacl_abi_stat *nasp']),
     ('NACL_sys_stat', 'NaClSysStat',
      ['const char *path', 'struct nacl_abi_stat *nasp']),
     ('NACL_sys_getdents', 'NaClSysGetdents',
      ['int d', 'void *buf', 'size_t count']),
-    ('NACL_sys_sysbrk', 'NaClSetBreak', ['uintptr_t new_break']),
+    ('NACL_sys_brk', 'NaClSysBrk', ['uintptr_t new_break']),
     ('NACL_sys_mmap', 'NaClSysMmap',
      ['void *start', 'size_t length', 'int prot',
       'int flags', 'int d', 'nacl_abi_off_t *offp']),
     ('NACL_sys_mprotect', 'NaClSysMprotect',
      ['uint32_t start', 'size_t length', 'int prot']),
     ('NACL_sys_munmap', 'NaClSysMunmap', ['void *start', 'size_t length']),
     ('NACL_sys_exit', 'NaClSysExit', ['int status']),
     ('NACL_sys_getpid', 'NaClSysGetpid', []),
     ('NACL_sys_thread_exit', 'NaClSysThreadExit',
      ['int32_t *stack_flag']),
@@ skipping 41 matching lines @@
       'struct nacl_abi_timespec *ts']),
     ('NACL_sys_imc_socketpair', 'NaClSysImcSocketPair',
      ['uint32_t descs_out']),
     ('NACL_sys_sem_create', 'NaClSysSemCreate', ['int32_t init_value']),
     ('NACL_sys_sem_wait', 'NaClSysSemWait', ['int32_t sem_handle']),
     ('NACL_sys_sem_post', 'NaClSysSemPost', ['int32_t sem_handle']),
     ('NACL_sys_sem_get_value', 'NaClSysSemGetValue',
      ['int32_t sem_handle']),
     ('NACL_sys_sched_yield', 'NaClSysSchedYield', []),
     ('NACL_sys_sysconf', 'NaClSysSysconf', ['int32_t name', 'int32_t *result']),
-    ('NACL_sys_dyncode_create', 'NaClTextSysDyncodeCreate',
+    ('NACL_sys_dyncode_create', 'NaClSysDyncodeCreate',
      ['uint32_t dest', 'uint32_t src', 'uint32_t size']),
-    ('NACL_sys_dyncode_modify', 'NaClTextSysDyncodeModify',
+    ('NACL_sys_dyncode_modify', 'NaClSysDyncodeModify',
      ['uint32_t dest', 'uint32_t src', 'uint32_t size']),
-    ('NACL_sys_dyncode_delete', 'NaClTextSysDyncodeDelete',
+    ('NACL_sys_dyncode_delete', 'NaClSysDyncodeDelete',
      ['uint32_t dest', 'uint32_t size']),
     ('NACL_sys_second_tls_set', 'NaClSysSecondTlsSet',
      ['uint32_t new_value']),
     ('NACL_sys_second_tls_get', 'NaClSysSecondTlsGet', []),
     ('NACL_sys_exception_handler', 'NaClSysExceptionHandler',
      ['uint32_t handler_addr', 'uint32_t old_handler']),
     ('NACL_sys_exception_stack', 'NaClSysExceptionStack',
      ['uint32_t stack_addr', 'uint32_t stack_size']),
     ('NACL_sys_exception_clear_flag', 'NaClSysExceptionClearFlag', []),
     ('NACL_sys_test_infoleak', 'NaClSysTestInfoLeak', []),
@@ skipping 125 matching lines @@
       subarch = val
     else:
       raise Exception('Unknown option: %s' % opt)
 
   if subarch != '':
     arch = arch + '-' + subarch
 
   if not ARG_REGISTERS.has_key(arch):
     raise Exception()
 
+  # Check naming consistency.
+  for syscall_number, func_name, alist in SYSCALL_LIST:
+    assert syscall_number.startswith('NACL_sys_'), syscall_number
+    name1 = syscall_number[len('NACL_sys_'):].replace('_', '')
+    assert func_name.startswith('NaClSys'), func_name
+    name2 = func_name[len('NaClSys'):].lower()
+    assert name1 == name2, '%r != %r' % (name1, name2)
+
   data = input_src.read()
   protos = SYSCALL_LIST
   print >>output_dst, data
   PrintImplSkel(arch, protos, output_dst)
   PrintSyscallTableInitializer(protos, output_dst)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))