Home shortcut should use touch icons when possible.

Home shortcut should use touch icons when possible.

Needs https://bugs.webkit.org/show_bug.cgi?id=109061 to actually use apple-touch-icons.

BUG=125076
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184863

[aruslan, 2013-02-05 20:25:05]

Please take a look and let me know if it makes sense. Thanks!

[Ramya, 2013-02-05 21:08:59]

There are multiple dimens.xml files. Please update the following if necessary.
chrome/android/java/res/values-sw600dp/dimens.xml
chrome/android/java/res/values-sw800dp/dimens.xml

[aruslan, 2013-02-26 21:01:26]

On 2013/02/05 21:08:59, Ramya wrote:
> There are multiple dimens.xml files. Please update the following if necessary.
> chrome/android/java/res/values-sw600dp/dimens.xml
> chrome/android/java/res/values-sw800dp/dimens.xml

Thanks, Ramya; it doesn't look like we have different values for sw600/800.

[Ramya, 2013-02-26 21:10:33]

lgtm

[aruslan, 2013-02-26 21:19:51]

hi Ted -- please review and apply your OWNERS seal if appropriate.
Thanks!

[Ted C, 2013-02-26 22:44:42]

lgtm w/ question

https://codereview.chromium.org/12209023/diff/4001/chrome/android/java/src/or...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java
(right):

https://codereview.chromium.org/12209023/diff/4001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:154:
canvas.drawBitmap(touchIcon, src, iconBounds, paint);
purely for my understanding, what is the benefit of the second draw instead of
using a clipping path?

[aruslan, 2013-02-27 00:18:09]

Thanks, Ted!

https://codereview.chromium.org/12209023/diff/4001/chrome/android/java/src/or...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java
(right):

https://codereview.chromium.org/12209023/diff/4001/chrome/android/java/src/or...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:154:
canvas.drawBitmap(touchIcon, src, iconBounds, paint);
On 2013/02/26 22:44:42, Ted C wrote:
> purely for my understanding, what is the benefit of the second draw instead of
> using a clipping path?

It doesn't look like there is a way to anti-alias clip paths/clip regions
(#include <disclaimer>).
The Romain Guy's solution (as brilliant as it is) seems to be a bit overkill in
this particular context.

Hence, the setXfermode.

[commit-bot: I haz the power, 2013-02-27 01:16:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/12209023/4001

[commit-bot: I haz the power, 2013-02-27 03:37:53]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-02-27 03:41:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/12209023/4001

[commit-bot: I haz the power, 2013-02-27 03:42:46]

Change committed as 184863