chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc - Issue 12209023: Home shortcut should use touch icons when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

Issue 12209023: Home shortcut should use touch icons when possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 10dp as per Roma. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

index ecc2879d2bb9ee5184fc95f4d02c38b9fcbf7a15..c29d4d85f79e3d3cb8b674287baa759d0c934e5e 100644

--- a/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

+++ b/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

@@ -389,9 +389,10 @@ void BookmarksHandler::HandleCreateHomeScreenBookmarkShortcut(

FaviconService::FaviconForURLParams(

profile,

node->url(),

- history::FAVICON | history::TOUCH_ICON,

- gfx::kFaviconSize),

- ui::GetMaxScaleFactor(),

+ history::TOUCH_PRECOMPOSED_ICON | history::TOUCH_ICON |

+ history::FAVICON,

+ 0), // request the largest icon.

+ ui::SCALE_FACTOR_100P, // density doesn't matter for the largest icon.

base::Bind(&BookmarksHandler::OnShortcutFaviconDataAvailable,

base::Unretained(this),

node),