Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 12208144: ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons(). (Closed)

Created:
7 years, 10 months ago by SanjoyPal
Modified:
7 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons(). BUG=175897 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
SanjoyPal
PTAL. Thanks
7 years, 10 months ago (2013-02-13 01:42:58 UTC) #1
Elliot Glaysher
lgtm
7 years, 10 months ago (2013-02-13 18:33:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/12208144/1
7 years, 10 months ago (2013-02-13 18:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/12208144/1
7 years, 10 months ago (2013-02-13 19:31:29 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 22:10:23 UTC) #5
Message was sent while issue was closed.
Change committed as 182318

Powered by Google App Engine
This is Rietveld 408576698