chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc - Issue 12208144: ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 12208144: ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons(). (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc (revision 181540)

+++ chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc (working copy)

@@ -135,10 +135,12 @@

prompt.HasAbortButtonLabel() ?

UTF16ToUTF8(prompt.GetAbortButtonLabel()).c_str() : GTK_STOCK_CANCEL,

GTK_RESPONSE_CLOSE);

- gtk_dialog_add_button(

- GTK_DIALOG(dialog_),

- UTF16ToUTF8(prompt.GetAcceptButtonLabel()).c_str(),

- GTK_RESPONSE_ACCEPT);

+ if (prompt.GetDialogButtons() & ui::DIALOG_BUTTON_OK) {

+ gtk_dialog_add_button(

+ GTK_DIALOG(dialog_),

+ UTF16ToUTF8(prompt.GetAcceptButtonLabel()).c_str(),

+ GTK_RESPONSE_ACCEPT);

+ }

#if !GTK_CHECK_VERSION(2, 22, 0)

gtk_dialog_set_has_separator(GTK_DIALOG(dialog_), FALSE);

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »