chrome/common/extensions/extension_set_unittest.cc - Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_set_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/extensions/features/base_feature_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_set_unittest.cc

===================================================================

--- chrome/common/extensions/extension_set_unittest.cc (revision 182296)

+++ chrome/common/extensions/extension_set_unittest.cc (working copy)

@@ -25,7 +25,7 @@

#endif

path = path.AppendASCII(name);

- DictionaryValue manifest;

+ base::DictionaryValue manifest;

manifest.SetString("name", name);

manifest.SetString("version", "1");

@@ -33,9 +33,9 @@

manifest.SetString("app.launch.web_url", launch_url);

if (!extent.empty()) {

- ListValue* urls = new ListValue();

+ base::ListValue* urls = new base::ListValue();

manifest.Set("app.urls", urls);

- urls->Append(Value::CreateStringValue(extent));

+ urls->Append(new base::StringValue(extent));

}

std::string error;

@@ -46,7 +46,7 @@

return extension;

}

-} // namespace

+} // namespace

TEST(ExtensionSetTest, ExtensionSet) {

scoped_refptr<Extension> ext1(CreateTestExtension(