Issue 12207105: [win] Remove 'installing...' icons from the app list if the install fails.

Issue 12207105: [win] Remove 'installing...' icons from the app list if the install fails. (Closed)

Created:
7 years, 10 months ago by koz (OOO until 15th September)

Modified:
7 years, 10 months ago

Reviewers:
xiyuan, benwells, Nico

CC:
chromium-reviews, Aaron Boodman, ben+watch_chromium.org, sadrul, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[win] Remove 'installing...' icons from the app list if the install fails. BUG=152854 TBR=thakis@chromium.org for stub method in cocoa Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181827

Patch Set 1 #

Patch Set 2 : fix mac #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
M	chrome/browser/extensions/api/webstore_private/webstore_private_api.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_util.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/apps_model_builder.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/apps_model_builder.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/app_list/app_list_controller_ash.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/app_list/app_list_controller_win.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12207105/1

7 years, 10 months ago (2013-02-11 18:35:47 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 10 months ago (2013-02-11 19:24:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/12207105/12002

7 years, 10 months ago (2013-02-11 22:24:45 UTC) #6

Nico

Please do not TBR cls against me without cc'ing me on the review thread. "TBR" ...

7 years, 10 months ago (2013-02-12 04:16:11 UTC) #8

koz (OOO until 15th September)

7 years, 10 months ago (2013-02-12 04:52:20 UTC) #9

Message was sent while issue was closed.

On 2013/02/12 04:16:11, Nico wrote:
> Please do not TBR cls against me without cc'ing me on the review thread. "TBR"
> means "to be reviewed", not "submitted without review by". How am I supposed
to
> know I'm to look at this if it never made it to my inbox?

Sorry Nico, I didn't realise TBRing someone didn't automatically include them on
the CC. I'll do so in the future.

Expand Messages | Collapse Messages