Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/ui/views/app_list/app_list_controller_win.cc

Issue 12207105: [win] Remove 'installing...' icons from the app list if the install fails. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/app_list/app_list_controller_win.cc
diff --git a/chrome/browser/ui/views/app_list/app_list_controller_win.cc b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
index 26e373bcb0eb75a5da3bbc5a3fe007907c69486b..5630e5675aff5bd852f7d3fa24c6dd5c27a9f534 100644
--- a/chrome/browser/ui/views/app_list/app_list_controller_win.cc
+++ b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
@@ -198,6 +198,7 @@ class AppListController : public ProfileInfoCacheObserver {
void OnDownloadProgress(Profile* profile,
const std::string& extension_id,
int percent_downloaded);
+ void OnInstallFailure(Profile* profile, const std::string& extension_id);
private:
// Loads a profile asynchronously and calls OnProfileLoaded() when done.
@@ -576,6 +577,18 @@ void AppListController::OnDownloadProgress(Profile* profile,
view_delegate_->OnDownloadProgress(extension_id, percent_downloaded);
}
+void AppListController::OnInstallFailure(Profile* profile,
+ const std::string& extension_id) {
+ // We only have a model for the current profile, so ignore events about
+ // others.
+ // TODO(koz): We should keep a model for each profile so we can record
+ // information like this.
+ if (profile != profile_)
+ return;
+
+ view_delegate_->OnInstallFailure(extension_id);
+}
+
// Attempts to find the bounds of the Windows taskbar. Returns true on success.
// |rect| is in screen coordinates. If the taskbar is in autohide mode and is
// not visible, |rect| will be outside the current monitor's bounds, except for
@@ -899,6 +912,12 @@ void NotifyAppListOfDownloadProgress(
percent_downloaded);
}
+void NotifyAppListOfExtensionInstallFailure(
+ Profile* profile,
+ const std::string& extension_id) {
+ g_app_list_controller.Get().OnInstallFailure(profile, extension_id);
+}
+
#endif // !defined(USE_ASH)
} // namespace chrome
« no previous file with comments | « chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698