Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12207089: Cleanup: Remove deprecated base::Value methods from contents. Use base::Value too. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, apatrick_chromium, sail+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Cleanup: Remove deprecated base::Value methods from contents. Use base::Value too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182042

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -302 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M content/browser/gpu/gpu_blacklist.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 17 chunks +47 lines, -49 lines 0 comments Download
M content/browser/media/media_internals.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M content/browser/media/media_internals_proxy.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/media/media_internals_unittest.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M content/browser/webui/web_ui_message_handler_unittest.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M content/common/common_param_traits_unittest.cc View 4 chunks +17 lines, -18 lines 0 comments Download
M content/common/font_list_mac.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/font_list_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/common/font_list_x11.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 7 chunks +18 lines, -29 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 15 chunks +34 lines, -39 lines 0 comments Download
M content/renderer/v8_value_converter_impl_unittest.cc View 1 24 chunks +66 lines, -60 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
7 years, 10 months ago (2013-02-09 02:14:01 UTC) #1
brettw
LGTM, thanks!
7 years, 10 months ago (2013-02-11 21:04:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207089/25
7 years, 10 months ago (2013-02-11 21:15:28 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=16158
7 years, 10 months ago (2013-02-11 22:03:43 UTC) #4
Lei Zhang
Patch set 2 has a 1 line change to make a test pass: new base::FundamentalValue(1) ...
7 years, 10 months ago (2013-02-12 17:36:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207089/11006
7 years, 10 months ago (2013-02-12 17:36:21 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98896
7 years, 10 months ago (2013-02-12 19:32:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207089/11006
7 years, 10 months ago (2013-02-12 19:43:26 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 22:28:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 182042

Powered by Google App Engine
This is Rietveld 408576698