Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: content/common/common_param_traits_unittest.cc

Issue 12207089: Cleanup: Remove deprecated base::Value methods from contents. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string.h> 5 #include <string.h>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "content/public/common/common_param_traits.h" 10 #include "content/public/common/common_param_traits.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 TestPair input("foo", "bar"); 72 TestPair input("foo", "bar");
73 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 73 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
74 IPC::ParamTraits<TestPair>::Write(&msg, input); 74 IPC::ParamTraits<TestPair>::Write(&msg, input);
75 75
76 TestPair output; 76 TestPair output;
77 PickleIterator iter(msg); 77 PickleIterator iter(msg);
78 EXPECT_TRUE(IPC::ParamTraits<TestPair>::Read(&msg, &iter, &output)); 78 EXPECT_TRUE(IPC::ParamTraits<TestPair>::Read(&msg, &iter, &output));
79 EXPECT_EQ(output.first, "foo"); 79 EXPECT_EQ(output.first, "foo");
80 EXPECT_EQ(output.second, "bar"); 80 EXPECT_EQ(output.second, "bar");
81
82 } 81 }
83 82
84 // Tests bitmap serialization. 83 // Tests bitmap serialization.
85 TEST(IPCMessageTest, Bitmap) { 84 TEST(IPCMessageTest, Bitmap) {
86 SkBitmap bitmap; 85 SkBitmap bitmap;
87 86
88 bitmap.setConfig(SkBitmap::kARGB_8888_Config, 10, 5); 87 bitmap.setConfig(SkBitmap::kARGB_8888_Config, 10, 5);
89 bitmap.allocPixels(); 88 bitmap.allocPixels();
90 memset(bitmap.getPixels(), 'A', bitmap.getSize()); 89 memset(bitmap.getPixels(), 'A', bitmap.getSize());
91 90
(...skipping 25 matching lines...) Expand all
117 scoped_array<char> bogus_pixels(new char[bogus_pixels_size]); 116 scoped_array<char> bogus_pixels(new char[bogus_pixels_size]);
118 memset(bogus_pixels.get(), 'B', bogus_pixels_size); 117 memset(bogus_pixels.get(), 'B', bogus_pixels_size);
119 bad_msg.WriteData(bogus_pixels.get(), bogus_pixels_size); 118 bad_msg.WriteData(bogus_pixels.get(), bogus_pixels_size);
120 // Make sure we don't read out the bitmap! 119 // Make sure we don't read out the bitmap!
121 SkBitmap bad_output; 120 SkBitmap bad_output;
122 iter = PickleIterator(bad_msg); 121 iter = PickleIterator(bad_msg);
123 EXPECT_FALSE(IPC::ParamTraits<SkBitmap>::Read(&bad_msg, &iter, &bad_output)); 122 EXPECT_FALSE(IPC::ParamTraits<SkBitmap>::Read(&bad_msg, &iter, &bad_output));
124 } 123 }
125 124
126 TEST(IPCMessageTest, ListValue) { 125 TEST(IPCMessageTest, ListValue) {
127 ListValue input; 126 base::ListValue input;
128 input.Set(0, Value::CreateDoubleValue(42.42)); 127 input.Set(0, new base::FundamentalValue(42.42));
129 input.Set(1, Value::CreateStringValue("forty")); 128 input.Set(1, new base::StringValue("forty"));
130 input.Set(2, Value::CreateNullValue()); 129 input.Set(2, base::Value::CreateNullValue());
131 130
132 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 131 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
133 IPC::WriteParam(&msg, input); 132 IPC::WriteParam(&msg, input);
134 133
135 ListValue output; 134 base::ListValue output;
136 PickleIterator iter(msg); 135 PickleIterator iter(msg);
137 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output)); 136 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
138 137
139 EXPECT_TRUE(input.Equals(&output)); 138 EXPECT_TRUE(input.Equals(&output));
140 139
141 // Also test the corrupt case. 140 // Also test the corrupt case.
142 IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL); 141 IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL);
143 bad_msg.WriteInt(99); 142 bad_msg.WriteInt(99);
144 iter = PickleIterator(bad_msg); 143 iter = PickleIterator(bad_msg);
145 EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output)); 144 EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output));
146 } 145 }
147 146
148 TEST(IPCMessageTest, DictionaryValue) { 147 TEST(IPCMessageTest, DictionaryValue) {
149 DictionaryValue input; 148 base::DictionaryValue input;
150 input.Set("null", Value::CreateNullValue()); 149 input.Set("null", base::Value::CreateNullValue());
151 input.Set("bool", Value::CreateBooleanValue(true)); 150 input.Set("bool", new base::FundamentalValue(true));
152 input.Set("int", Value::CreateIntegerValue(42)); 151 input.Set("int", new base::FundamentalValue(42));
153 152
154 scoped_ptr<DictionaryValue> subdict(new DictionaryValue()); 153 scoped_ptr<base::DictionaryValue> subdict(new base::DictionaryValue());
155 subdict->Set("str", Value::CreateStringValue("forty two")); 154 subdict->Set("str", new base::StringValue("forty two"));
156 subdict->Set("bool", Value::CreateBooleanValue(false)); 155 subdict->Set("bool", new base::FundamentalValue(false));
157 156
158 scoped_ptr<ListValue> sublist(new ListValue()); 157 scoped_ptr<base::ListValue> sublist(new base::ListValue());
159 sublist->Set(0, Value::CreateDoubleValue(42.42)); 158 sublist->Set(0, new base::FundamentalValue(42.42));
160 sublist->Set(1, Value::CreateStringValue("forty")); 159 sublist->Set(1, new base::StringValue("forty"));
161 sublist->Set(2, Value::CreateStringValue("two")); 160 sublist->Set(2, new base::StringValue("two"));
162 subdict->Set("list", sublist.release()); 161 subdict->Set("list", sublist.release());
163 162
164 input.Set("dict", subdict.release()); 163 input.Set("dict", subdict.release());
165 164
166 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 165 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
167 IPC::WriteParam(&msg, input); 166 IPC::WriteParam(&msg, input);
168 167
169 DictionaryValue output; 168 base::DictionaryValue output;
170 PickleIterator iter(msg); 169 PickleIterator iter(msg);
171 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output)); 170 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
172 171
173 EXPECT_TRUE(input.Equals(&output)); 172 EXPECT_TRUE(input.Equals(&output));
174 173
175 // Also test the corrupt case. 174 // Also test the corrupt case.
176 IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL); 175 IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL);
177 bad_msg.WriteInt(99); 176 bad_msg.WriteInt(99);
178 iter = PickleIterator(bad_msg); 177 iter = PickleIterator(bad_msg);
179 EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output)); 178 EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output));
180 } 179 }
181 180
182 // Tests net::HostPortPair serialization 181 // Tests net::HostPortPair serialization
183 TEST(IPCMessageTest, HostPortPair) { 182 TEST(IPCMessageTest, HostPortPair) {
184 net::HostPortPair input("host.com", 12345); 183 net::HostPortPair input("host.com", 12345);
185 184
186 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 185 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
187 IPC::ParamTraits<net::HostPortPair>::Write(&msg, input); 186 IPC::ParamTraits<net::HostPortPair>::Write(&msg, input);
188 187
189 net::HostPortPair output; 188 net::HostPortPair output;
190 PickleIterator iter(msg); 189 PickleIterator iter(msg);
191 EXPECT_TRUE(IPC::ParamTraits<net::HostPortPair>::Read(&msg, &iter, &output)); 190 EXPECT_TRUE(IPC::ParamTraits<net::HostPortPair>::Read(&msg, &iter, &output));
192 EXPECT_EQ(input.host(), output.host()); 191 EXPECT_EQ(input.host(), output.host());
193 EXPECT_EQ(input.port(), output.port()); 192 EXPECT_EQ(input.port(), output.port());
194 } 193 }
OLDNEW
« no previous file with comments | « content/browser/webui/web_ui_message_handler_unittest.cc ('k') | content/common/font_list_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698