Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 12207003: Add TRACE calls for all gpu driver calls (Closed)

Created:
7 years, 10 months ago by greggman
Modified:
7 years, 10 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add TRACE calls for all gpu driver calls Adds a switch --enable-gpu-service-tracing that calls TRACE on every gpu-process call into the GL driver. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181212

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -8 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/unittest_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/generate_bindings.py View 3 chunks +26 lines, -1 line 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 chunk +16 lines, -0 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 4 chunks +23 lines, -2 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
greggman
Hey Al, PTAL
7 years, 10 months ago (2013-02-05 01:11:45 UTC) #1
apatrick_chromium
lgtm
7 years, 10 months ago (2013-02-05 21:28:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12207003/1
7 years, 10 months ago (2013-02-05 21:32:32 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests, gpu_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=81198
7 years, 10 months ago (2013-02-05 22:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12207003/13001
7 years, 10 months ago (2013-02-06 00:37:46 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/browser/gpu/gpu_process_host.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-06 00:37:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12207003/4004
7 years, 10 months ago (2013-02-07 02:39:00 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 05:21:17 UTC) #8
Message was sent while issue was closed.
Change committed as 181212

Powered by Google App Engine
This is Rietveld 408576698