Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 12155003: Use the correct number of WaveOut buffers on XP... (Closed)

Created:
6 years, 4 months ago by DaleCurtis
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Use the correct number of WaveOut buffers on XP... Reverts a buffer size increase added in http://crrev.com/168111 and hacks added in http://crrev.com/169553 BUG=161307 TEST=Flash, HTML5 playback smoothly -- even in the background. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180102

Patch Set 1 : Delete hacks. #

Patch Set 2 : Useless header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M media/audio/audio_output_resampler.cc View 1 4 chunks +1 line, -24 lines 0 comments Download
M media/audio/audio_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
6 years, 4 months ago (2013-02-01 01:20:47 UTC) #1
scherkus (not reviewing)
this seems to contain a number of reverts of other experiments would it be possible ...
6 years, 4 months ago (2013-02-01 01:22:43 UTC) #2
DaleCurtis
Done. No full reverts, just pieces here and there.
6 years, 4 months ago (2013-02-01 01:32:31 UTC) #3
scherkus (not reviewing)
lgtm thanks! lgtm -- here's hoping ;)
6 years, 4 months ago (2013-02-01 01:33:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/12155003/7001
6 years, 4 months ago (2013-02-01 01:54:49 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2013-02-01 06:26:37 UTC) #6
Message was sent while issue was closed.
Change committed as 180102

Powered by Google App Engine
This is Rietveld 408576698