Issue 1212673003: Fix position-change-to-absolute-with-positioned-child-crash.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1212673003: Fix position-change-to-absolute-with-positioned-child-crash.html (Closed)

Created:
5 years, 5 months ago by kojii

Modified:
5 years, 5 months ago

Reviewers:
mstensho (USE GERRIT)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix position-change-to-absolute-with-positioned-child-crash.html This patch fixes a bug that was introduced in a late refactoring to the test added in a CL to fix dynamic change to positioned objects[1]. The bug initialized tests array within the inner loop that not all tests ran. Fixed to initialize at the beginning. [1] https://codereview.chromium.org/1181983002 BUG=407356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198098

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	LayoutTests/fast/dynamic/position-change-to-absolute-with-positioned-child-crash.html	View		2 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212673003/1

5 years, 5 months ago (2015-06-30 19:44:55 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-06-30 20:47:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198098

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages