Issue 12096099: PPAPI: Fix WebSocket Var ref leak receiving binary

Issue 12096099: PPAPI: Fix WebSocket Var ref leak receiving binary (Closed)

Created:
7 years, 10 months ago by dmichael (off chromium)

Modified:
7 years, 10 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Fix WebSocket Var ref leak receiving binary BUG=173503 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180093 Reopened; was reverted here: https://src.chromium.org/viewvc/chrome?view=rev&revision=180105 Tests were failing because the IRT was not rebuilt due to a gyp problem, which was fixed here: https://src.chromium.org/viewvc/chrome?view=rev&revision=180182 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180190 Reverted again due to 2 tests still failing on Windows 7 and XP: https://src.chromium.org/viewvc/chrome?view=rev&revision=180239 They're failing the new leak check. It's not clear yet if that's a real leak or another build issue; I will investigate separately. This CL still fixes a serious leak on all platforms, so landing without the leak check for now to keep the tests green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180428

Patch Set 2 : Re-upload to make sure it's unchanged... #

Patch Set 3 : Remove the leak check until I can figure out why it still fails for 2 Windows tests. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
M	ppapi/proxy/websocket_resource.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/shared_impl/var_tracker.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/var_tracker.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	ppapi/tests/test_case.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_websocket.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

https://codereview.chromium.org/12096099/diff/1/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): https://codereview.chromium.org/12096099/diff/1/ppapi/tests/test_websocket.cc#newcode467 ppapi/tests/test_websocket.cc:467: ReleaseVar(extensions); ^^^ This is unrelated, but required to make ...

7 years, 10 months ago (2013-01-31 22:53:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12096099/1

7 years, 10 months ago (2013-02-01 01:13:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12096099/16001

7 years, 10 months ago (2013-02-02 16:46:26 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12096099/16001

7 years, 10 months ago (2013-02-04 15:14:16 UTC) #6

Message was sent while issue was closed.

Change committed as 180428

Expand Messages | Collapse Messages