ppapi/proxy/websocket_resource.cc - Issue 12096099: PPAPI: Fix WebSocket Var ref leak receiving binary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/websocket_resource.cc

Issue 12096099: PPAPI: Fix WebSocket Var ref leak receiving binary (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove the leak check until I can figure out why it still fails for 2 Windows tests. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/websocket_resource.cc

diff --git a/ppapi/proxy/websocket_resource.cc b/ppapi/proxy/websocket_resource.cc

index c45de909b55e6b36744d513c90375e450ba9ef9c..7439826dba18dc5596912d0e9bb0cbdbb24d59b8 100644

--- a/ppapi/proxy/websocket_resource.cc

+++ b/ppapi/proxy/websocket_resource.cc

@@ -423,10 +423,10 @@ void WebSocketResource::OnPluginMsgReceiveBinaryReply(

return;

// Append received data to queue.

- scoped_refptr<Var> message_var(ArrayBufferVar::FromPPVar(

- PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(

+ scoped_refptr<Var> message_var(

+ PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferVar(

message.size(),

- &message.front())));

+ &message.front()));

received_messages_.push(message_var);

if (!TrackedCallback::IsPending(receive_callback_))

« no previous file with comments | « no previous file | ppapi/shared_impl/var_tracker.h » ('j') | no next file with comments »