Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 12095071: Convert top controls to use DIP instead of PX. (Closed)

Created:
7 years, 10 months ago by Ted C
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Visibility:
Public.

Description

Convert top controls to use DIP instead of PX. Previously, scroll offset was based on screen pixels, but now is based on screen density independent pixels. This converts the top controls manager to deal in DIP instead of PX. BUG=161303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M cc/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +5 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted C
7 years, 10 months ago (2013-01-30 23:52:23 UTC) #1
jamesr
lgtm for webkit/compositor_bindings/, rest is up to aelias@
7 years, 10 months ago (2013-01-31 00:00:11 UTC) #2
aelias_OOO_until_Jul13
It might be easier to have the flag take an integer and convert to DIP ...
7 years, 10 months ago (2013-01-31 09:53:10 UTC) #3
Ted C
On 2013/01/31 09:53:10, aelias wrote: > It might be easier to have the flag take ...
7 years, 10 months ago (2013-01-31 18:22:59 UTC) #4
aelias_OOO_until_Jul13
lgtm OK, let's go with this as is.
7 years, 10 months ago (2013-01-31 22:43:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/12095071/1
7 years, 10 months ago (2013-01-31 23:03:10 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:47:31 UTC) #7
Message was sent while issue was closed.
Change committed as 180089

Powered by Google App Engine
This is Rietveld 408576698