Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller.h

Issue 12094069: [autofill] Hook the sign-in button up to required actions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: +snark Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller.h b/chrome/browser/ui/autofill/autofill_dialog_controller.h
index f68c170f70a2cb6ac140672c50e599daf91b224e..04da3e2f6376c17bc7cda84c635f878d1b802b4d 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller.h
@@ -9,6 +9,7 @@
#include "base/string16.h"
#include "chrome/browser/autofill/field_types.h"
+#include "chrome/browser/autofill/wallet/required_action.h"
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/native_widget_types.h"
@@ -47,6 +48,11 @@ class AutofillDialogController {
virtual string16 CancelSignInText() const = 0;
virtual string16 SaveLocallyText() const = 0;
+ // State ---------------------------------------------------------------------
+
+ virtual bool IsSignedIn() const = 0;
+ virtual bool HasReceivedWalletResponse() const = 0;
+
// Detail inputs -------------------------------------------------------------
// Returns the set of inputs the page has requested which fall under
@@ -93,7 +99,10 @@ class AutofillDialogController {
// whether the Autofill operation should be aborted.
virtual void ViewClosed(DialogAction action) = 0;
- // Returns any dialog notification that should currently be showing.
+ // Any actions the user will be required to take before continuing.
+ virtual std::vector<wallet::RequiredAction> RequiredActions() const = 0;
Ilya Sherman 2013/01/31 02:33:07 nit: Shouldn't this be defined on the Impl class?
Dan Beam 2013/01/31 02:48:51 D'oh, was using in |view_| before but forgot to re
+
+ // Any pending security information the user should be notified of.
virtual DialogNotification CurrentNotification() const = 0;
Ilya Sherman 2013/01/31 02:33:07 nit: If this is only for security notifications, p
Dan Beam 2013/01/31 02:48:51 It's not, there's required actions and there will
Ilya Sherman 2013/01/31 04:35:44 In that case, maybe don't call out security explic
Dan Beam 2013/01/31 21:04:26 Done.
// Begins the flow to sign into Wallet.

Powered by Google App Engine
This is Rietveld 408576698