[autofill] Hook the sign-in button up to required actions.

chrome/browser/ui/autofill/autofill_dialog_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_H_
 
 #include <vector>
 
 #include "base/string16.h"
 #include "chrome/browser/autofill/field_types.h"
+#include "chrome/browser/autofill/wallet/required_action.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Profile;
 
 namespace content {
 class WebContents;
 struct NativeWebKeyboardEvent;
 }
@@ skipping 18 matching lines @@
   virtual string16 DialogTitle() const = 0;
   virtual string16 EditSuggestionText() const = 0;
   virtual string16 UseBillingForShippingText() const = 0;
   virtual string16 WalletOptionText() const = 0;
   virtual string16 CancelButtonText() const = 0;
   virtual string16 ConfirmButtonText() const = 0;
   virtual string16 SignInText() const = 0;
   virtual string16 CancelSignInText() const = 0;
   virtual string16 SaveLocallyText() const = 0;
 
+  // State ---------------------------------------------------------------------
+
+  virtual bool IsSignedIn() const = 0;
+  virtual bool HasReceivedWalletResponse() const = 0;
+
   // Detail inputs -------------------------------------------------------------
 
   // Returns the set of inputs the page has requested which fall under
   // |section|.
   virtual const DetailInputs& RequestedFieldsForSection(DialogSection section)
       const = 0;
 
   // Returns the combobox model for inputs of type |type|, or NULL if the input
   // should be a text field.
   virtual ui::ComboboxModel* ComboboxModelForAutofillType(
@@ skipping 26 matching lines @@
 
   // Called when focus has changed position within the view.
   virtual void FocusMoved() = 0;
 
   // Miscellany ----------------------------------------------------------------
 
   // Called when the view has been closed. The value for |action| indicates
   // whether the Autofill operation should be aborted.
   virtual void ViewClosed(DialogAction action) = 0;
 
-  // Returns any dialog notification that should currently be showing.
+  // Any actions the user will be required to take before continuing.
+  virtual std::vector<wallet::RequiredAction> RequiredActions() const = 0;

[Ilya Sherman, 2013/01/31 02:33:07]

nit: Shouldn't this be defined on the Impl class?

[Dan Beam, 2013/01/31 02:48:51]

D'oh, was using in |view_| before but forgot to remove (did it 2 other places,
but not the *third*, >:/).

+
+  // Any pending security information the user should be notified of.
   virtual DialogNotification CurrentNotification() const = 0;

[Ilya Sherman, 2013/01/31 02:33:07]

nit: If this is only for security notifications, perhaps name the method
CurrentSecurityNotification?

[Dan Beam, 2013/01/31 02:48:51]

It's not, there's required actions and there will be other things as well (see:
autofill_dialog_types.h for definition of the types of DialogNotifications).

[Ilya Sherman, 2013/01/31 04:35:44]

In that case, maybe don't call out security explicitly in the comment?

[Dan Beam, 2013/01/31 21:04:26]

Done.

 
   // Begins the flow to sign into Wallet.
   virtual void StartSignInFlow() = 0;
 
   // Marks the signin flow into Wallet complete.
   virtual void EndSignInFlow() = 0;
 
   // Returns the profile for this dialog.
   virtual Profile* profile() = 0;
 
   // The web contents that prompted the dialog.
   virtual content::WebContents* web_contents() = 0;
 
  protected:
   virtual ~AutofillDialogController();
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_H_