Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 12094024: Revert "Merged all Chromoting Host code into remoting_core.dll (Windows)." (Closed)

Created:
7 years, 10 months ago by mattm
Modified:
7 years, 10 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert "Merged all Chromoting Host code into remoting_core.dll (Windows)." This reverts commit r179226. Broke mac dbg build. > Merged all Chromoting Host code into remoting_core.dll (Windows). > > Consolidated all installable Chromoting Host core into remoting_core.dll and converted all executables into thin wrappers around entry points exposed by remoting_core.dll. This reduces size of the installer by approximately 600KB. > > BUG=170200 > > Review URL: https://chromiumcodereview.appspot.com/11970044 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -834 lines) Patch
remoting/branding_Chrome View 1 chunk +0 lines, -1 line 0 comments Download
remoting/branding_Chromium View 1 chunk +0 lines, -1 line 0 comments Download
remoting/host/continue_window_win.cc View 2 chunks +8 lines, -5 lines 0 comments Download
remoting/host/desktop_process_main.h View 1 chunk +0 lines, -17 lines 0 comments Download
remoting/host/desktop_process_main.cc View 5 chunks +46 lines, -50 lines 0 comments Download
remoting/host/disconnect_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/host_export.h View 1 chunk +0 lines, -24 lines 0 comments Download
remoting/host/host_ui.rc View 3 chunks +42 lines, -32 lines 0 comments Download
remoting/host/host_ui_resource.h View 2 chunks +4 lines, -19 lines 0 comments Download
remoting/host/installer/win/chromoting.wxs View 8 chunks +14 lines, -25 lines 0 comments Download
remoting/host/installer/win/parameters.json View 1 chunk +0 lines, -1 line 0 comments Download
remoting/host/plugin/host_plugin.cc View 1 chunk +3 lines, -0 lines 0 comments Download
remoting/host/remoting_desktop.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
remoting/host/remoting_host_me2me.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
remoting/host/remoting_me2me_host.h View 1 chunk +0 lines, -17 lines 0 comments Download
remoting/host/remoting_me2me_host.cc View 7 chunks +58 lines, -46 lines 0 comments Download
remoting/host/verify_config_window_win.h View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/verify_config_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/video_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/win/core.cc View 1 chunk +0 lines, -14 lines 0 comments Download
remoting/host/win/core.rc View 1 chunk +0 lines, -90 lines 0 comments Download
remoting/host/win/core_resource.h View 1 chunk +0 lines, -42 lines 0 comments Download
remoting/host/win/daemon_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
remoting/host/win/daemon_process_main.h View 1 chunk +0 lines, -17 lines 0 comments Download
remoting/host/win/daemon_process_main.cc View 1 chunk +0 lines, -89 lines 0 comments Download
remoting/host/win/desktop_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
remoting/host/win/elevated_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/win/elevated_controller.rc View 1 chunk +69 lines, -0 lines 0 comments Download
remoting/host/win/elevated_controller_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
remoting/host/win/elevated_controller_module.h View 1 chunk +0 lines, -17 lines 0 comments Download
remoting/host/win/elevated_controller_module.cc View 4 chunks +12 lines, -10 lines 0 comments Download
remoting/host/win/elevated_controller_resource.h View 1 chunk +19 lines, -0 lines 0 comments Download
remoting/host/win/host_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
remoting/host/win/host_service.cc View 5 chunks +62 lines, -1 line 0 comments Download
remoting/host/win/host_service.rc View 3 chunks +15 lines, -19 lines 0 comments Download
remoting/host/win/host_service_resource.h View 1 chunk +4 lines, -3 lines 0 comments Download
remoting/host/win/remoting_core.ver View 1 chunk +0 lines, -4 lines 0 comments Download
remoting/host/win/remoting_desktop.ver View 1 chunk +0 lines, -4 lines 0 comments Download
remoting/host/win/remoting_host.ver View 1 chunk +0 lines, -4 lines 0 comments Download
remoting/remoting.gyp View 17 chunks +196 lines, -220 lines 0 comments Download
remoting/version.rc.version View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mattm
7 years, 10 months ago (2013-01-29 05:19:05 UTC) #1
Message was sent while issue was closed.
ex:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/26058/step...
[8618/17179] CXX
obj/third_party/webkit/source/webcore/modules/quota/webcore_remaining.storageinfo.o
FAILED: ./gyp-mac-tool flock linker.lock clang++ -Wl,-search_paths_first
-Wl,-ObjC -Wl,-pie -mmacosx-version-min=10.6 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-arch i386 -L. -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -o
remoting_me2me_host.app/Contents/MacOS/remoting_me2me_host
obj/remoting/host/remoting_me2me_host.remoting_me2me_host.o
libdynamic_annotations.a libremoting_host.a libopus.a libbreakpad_utilities.a
libchromotocol_proto_lib.a libspeex.a libremoting_jingle_glue.a
libremoting_host_logging.a libjingle_glue.a libjingle.a libvpx_asm_offsets_vp9.a
libvpx_intrinsics.a libnotifier.a libchrome_zlib.a libssl.a libjsoncpp.a
libjingle_p2p.a libyuv_convert_simd_x86.a libremoting_breakpad.a
libvpx_asm_offsets.a libremoting_base.a libexpat.a libgoogle_apis.a
libremoting_protocol.a libvpx.a libprotobuf_lite.a libbreakpad.a
libyuv_convert.a libremoting_host_event_logger.a libremoting_me2me_host_static.a
libcrcrypto.dylib libskia.dylib libgoogleurl.dylib libmedia.dylib libnet.dylib
libbase.dylib libipc.dylib libui.dylib libbase_i18n.dylib libcrnspr.dylib
libcrnss.dylib libshared_memory_support.dylib -framework AppKit -framework
ApplicationServices -framework Carbon -framework CoreFoundation -framework
Foundation -framework IOKit -framework Security -framework AudioToolbox
-framework AudioUnit -framework CoreAudio -framework CoreVideo -framework OpenGL
-framework QTKit -framework SystemConfiguration
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/lib/libresolv.dylib
-framework Accelerate -framework CoreServices
Undefined symbols for architecture i386:
  "_pam_acct_mgmt", referenced from:
      remoting::(anonymous namespace)::PamAuthorizer::IsLocalLoginAllowed() in
libremoting_host.a(remoting_host.pam_authorization_factory_posix.o)
  "_pam_end", referenced from:
      remoting::(anonymous namespace)::PamAuthorizer::IsLocalLoginAllowed() in
libremoting_host.a(remoting_host.pam_authorization_factory_posix.o)
  "_pam_start", referenced from:
      remoting::(anonymous namespace)::PamAuthorizer::IsLocalLoginAllowed() in
libremoting_host.a(remoting_host.pam_authorization_factory_posix.o)
ld: symbol(s) not found for architecture i386
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.


http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...
____Ld
../xcodebuild/Release/remoting_me2me_host.app/Contents/MacOS/remoting_me2me_host
    cd /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/remoting
    setenv DISTCC_HOSTS goma,cpp,lzo
    setenv INCLUDE_SERVER_DIR /tmp/distcc-pump.eVWoYL
    setenv INCLUDE_SERVER_PID 1336
    setenv INCLUDE_SERVER_PORT /tmp/distcc-pump.eVWoYL/socket
    setenv MACOSX_DEPLOYMENT_TARGET 10.6
    setenv PATH
"/usr/bin:/Developer/usr/bin:/Users/chrome-bot/slavebin:/Volumes/data/b/depot_tools:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin"
   
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/remoting/../third_party/llvm-build/Release+Asserts/bin/clang++
 [[SNIP]]
Undefined symbols:
  "_pam_start", referenced from:
      __ZN8remoting12_GLOBAL__N_113PamAuthorizer20MaybeCheckLocalLoginEv in
libremoting_host.a(pam_authorization_factory_posix.o)
  "_pam_acct_mgmt", referenced from:
      __ZN8remoting12_GLOBAL__N_113PamAuthorizer20MaybeCheckLocalLoginEv in
libremoting_host.a(pam_authorization_factory_posix.o)
  "_pam_end", referenced from:
      __ZN8remoting12_GLOBAL__N_113PamAuthorizer20MaybeCheckLocalLoginEv in
libremoting_host.a(pam_authorization_factory_posix.o)
ld: symbol(s) not found
clang:error: linker command failed with exit code 1 (use -v to see invocation)

Powered by Google App Engine
This is Rietveld 408576698