Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 12093096: Add Release versions (Closed)

Created:
7 years, 10 months ago by noelallen1
Modified:
7 years, 10 months ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

Add Release versions Add a release build of the libraries so that users don't need to build it themselves. NOTRY=true R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180038

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 3 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
noelallen1
ptal
7 years, 10 months ago (2013-01-31 20:07:32 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/12093096/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/12093096/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode741 native_client_sdk/src/build_tools/build_sdk.py:741: clean=False, deps=True, config='Debug'): Maybe make this a required ...
7 years, 10 months ago (2013-01-31 20:09:27 UTC) #2
noelallen1
https://codereview.chromium.org/12093096/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/12093096/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode741 native_client_sdk/src/build_tools/build_sdk.py:741: clean=False, deps=True, config='Debug'): Those are the only two call ...
7 years, 10 months ago (2013-01-31 20:59:24 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-01-31 22:00:40 UTC) #4
binji
lgtm
7 years, 10 months ago (2013-01-31 22:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/12093096/1
7 years, 10 months ago (2013-02-01 00:24:07 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 01:52:07 UTC) #7
Message was sent while issue was closed.
Change committed as 180038

Powered by Google App Engine
This is Rietveld 408576698