Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 12093096: Add Release versions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index 38a5e4b5c4fc4c5a56fa611c823f8b73db2c0e7c..fcc4fe5c196c27602d1ea8363fcb6f29dd98213c 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -738,7 +738,7 @@ def GetWindowsEnvironment():
def BuildStepMakeAll(pepperdir, platform, directory, step_name,
- clean=False, deps=True):
+ clean=False, deps=True, config='Debug'):
Sam Clegg 2013/01/31 20:09:27 Maybe make this a required (non-default) arg if th
noelallen1 2013/01/31 20:59:24 Those are the only two call sites in this file. P
buildbot_common.BuildStep(step_name)
make_dir = os.path.join(pepperdir, directory)
makefile = os.path.join(make_dir, 'Makefile')
@@ -752,7 +752,7 @@ def BuildStepMakeAll(pepperdir, platform, directory, step_name,
env = os.environ
make = 'make'
- extra_args = []
+ extra_args = ['CONFIG='+config]
if not deps:
extra_args += ['IGNORE_DEPS=1']
@@ -765,8 +765,10 @@ def BuildStepMakeAll(pepperdir, platform, directory, step_name,
def BuildStepBuildLibraries(pepperdir, platform, directory, clean=True):
- BuildStepMakeAll(pepperdir, platform, directory, 'Build Libraries',
- clean=clean)
+ BuildStepMakeAll(pepperdir, platform, directory, 'Build Libraries Debug',
+ clean=clean, config='Debug')
+ BuildStepMakeAll(pepperdir, platform, directory, 'Build Libraries Release',
+ clean=clean, config='Release')
def BuildStepGenerateNotice(pepperdir):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698