Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4355)

Unified Diff: chrome/common/extensions/api/commands/commands_handler.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/commands/commands_handler.cc
diff --git a/chrome/common/extensions/api/commands/commands_handler.cc b/chrome/common/extensions/api/commands/commands_handler.cc
index 8cfafcc22ec700f006a28d05cafe0d5345d1cbf9..26a2216ac7dee36928033b26d5a00ff6bbc63654 100644
--- a/chrome/common/extensions/api/commands/commands_handler.cc
+++ b/chrome/common/extensions/api/commands/commands_handler.cc
@@ -8,7 +8,6 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/manifest.h"
#include "extensions/common/error_utils.h"
namespace keys = extension_manifest_keys;
@@ -125,10 +124,10 @@ bool CommandsHandler::Parse(Extension* extension, string16* error) {
return true;
}
-bool CommandsHandler::AlwaysParseForType(Extension::Type type) {
- return type == Extension::TYPE_EXTENSION ||
- type == Extension::TYPE_LEGACY_PACKAGED_APP ||
- type == Extension::TYPE_PLATFORM_APP;
+bool CommandsHandler::AlwaysParseForType(Manifest::Type type) {
+ return type == Manifest::TYPE_EXTENSION ||
+ type == Manifest::TYPE_LEGACY_PACKAGED_APP ||
+ type == Manifest::TYPE_PLATFORM_APP;
}
void CommandsHandler::MaybeSetBrowserActionDefault(const Extension* extension,

Powered by Google App Engine
This is Rietveld 408576698