Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/common/extensions/api/commands/commands_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/commands/commands_handler.h"
 
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/manifest.h"
 #include "extensions/common/error_utils.h"
 
 namespace keys = extension_manifest_keys;
 
 namespace extensions {
 
 namespace {
 // The maximum number of commands (including page action/browser actions) an
 // extension can have.
 const size_t kMaxCommandsPerExtension = 4;
@@ skipping 96 matching lines @@
     }
   }
 
   MaybeSetBrowserActionDefault(extension, commands_info.get());
 
   extension->SetManifestData(keys::kCommands,
                              commands_info.release());
   return true;
 }
 
-bool CommandsHandler::AlwaysParseForType(Extension::Type type) {
-  return type == Extension::TYPE_EXTENSION ||
-      type == Extension::TYPE_LEGACY_PACKAGED_APP ||
-      type == Extension::TYPE_PLATFORM_APP;
+bool CommandsHandler::AlwaysParseForType(Manifest::Type type) {
+  return type == Manifest::TYPE_EXTENSION ||
+      type == Manifest::TYPE_LEGACY_PACKAGED_APP ||
+      type == Manifest::TYPE_PLATFORM_APP;
 }
 
 void CommandsHandler::MaybeSetBrowserActionDefault(const Extension* extension,
                                                    CommandsInfo* info) {
   if (extension->manifest()->HasKey(keys::kBrowserAction) &&
       !info->browser_action_command.get()) {
     info->browser_action_command.reset(new Command(
         extension_manifest_values::kBrowserActionCommandEvent, string16(), ""));
   }
 }
 
 }  // namespace extensions