chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc » ('j') | extensions/common/install_warning.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

index d3ba8b2e9b861b35d35945d38b88deaae56af984..a0b2c7013ce6bda193fbca90f0b25a7696495185 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

@@ -6,6 +6,7 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

+#include "chrome/common/extensions/manifest.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace errors = extension_manifest_errors;

@@ -20,7 +21,7 @@ TEST_F(ExtensionManifestTest, ChromeResourcesPermissionValidOnlyForComponents) {

errors::kInvalidPermissionScheme);

std::string error;

LoadExtension(Manifest("permission_chrome_resources_url.json"),

- &error, extensions::Extension::COMPONENT,

+ &error, extensions::Manifest::COMPONENT,

extensions::Extension::NO_FLAGS);

EXPECT_EQ("", error);

}