chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifest_test.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc » ('j') | extensions/common/install_warning.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc

index e99832279ac1aa6d9af8dc29f4ed5cab201cd7dc..7a0ac140e0d5e3897d17d187b3edd9092cecd482 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_auth_unittest.cc

@@ -4,8 +4,9 @@

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

-#include "testing/gtest/include/gtest/gtest.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

+#include "extensions/common/install_warning.h"

+#include "testing/gtest/include/gtest/gtest.h"

namespace keys = extension_manifest_keys;

@@ -64,7 +65,7 @@ TEST_F(ExtensionManifestTest, OAuth2SectionParsing) {

scoped_refptr<extensions::Extension> extension =

LoadAndExpectSuccess(manifest);

EXPECT_EQ(1U, extension->install_warnings().size());

- const extensions::Extension::InstallWarning& warning =

+ const extensions::InstallWarning& warning =

extension->install_warnings()[0];

EXPECT_EQ("'oauth2' is only allowed for extensions, legacy packaged apps "

"and packaged apps, and this is a hosted app.",