Merged all Chromoting Host code into remoting_core.dll (Windows).

Merged all Chromoting Host code into remoting_core.dll (Windows).

Consolidated all installable Chromoting Host core into remoting_core.dll and converted all executables into thin wrappers around entry points exposed by remoting_core.dll. This reduces size of the installer by approximately 600KB.

This is the 3rd attempt to land this CL. The previous attempt was reverted at r179373 because ninja sometimes failed to create a manifest for targets that use manifestXXX linker flags. This CL fixes that by manually embedding the manifests into binaries.

BUG=170200, 173052
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180433

[alexeypa (please no reviews), 2013-02-01 19:12:16]

scottmg@ - PTAL at the patch set #2.
sergeyu@ - please rubber stamp re-landing of #1.

#1 is the original https://chromiumcodereview.appspot.com/12088049/.

#2 is the GYP-only change that makes sure that get proper manifests embedded.

[scottmg, 2013-02-01 19:21:21]

yuck :/ lgtm

[Sergey Ulanov, 2013-02-01 20:14:12]

LGTM

https://chromiumcodereview.appspot.com/12092117/diff/2001/remoting/host/win/r...
File remoting/host/win/remoting_desktop.manifest (right):

https://chromiumcodereview.appspot.com/12092117/diff/2001/remoting/host/win/r...
remoting/host/win/remoting_desktop.manifest:6: <requestedExecutionLevel
level="requireAdministrator" uiAccess="true"></requestedExecutionLevel>
nit: How is this file generated? If it you created it manually then this line
can be replaced with the following:
  <requestedExecutionLevel level="requireAdministrator" uiAccess="true" />

Just to make it shorter.

[alexeypa (please no reviews), 2013-02-01 21:09:16]

https://chromiumcodereview.appspot.com/12092117/diff/2001/remoting/host/win/r...
File remoting/host/win/remoting_desktop.manifest (right):

https://chromiumcodereview.appspot.com/12092117/diff/2001/remoting/host/win/r...
remoting/host/win/remoting_desktop.manifest:6: <requestedExecutionLevel
level="requireAdministrator" uiAccess="true"></requestedExecutionLevel>
On 2013/02/01 20:14:12, sergeyu wrote:
> nit: How is this file generated? If it you created it manually then this line
> can be replaced with the following:
>   <requestedExecutionLevel level="requireAdministrator" uiAccess="true" />
> 
> Just to make it shorter.

Done.

[commit-bot: I haz the power, 2013-02-01 21:22:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12092117/8003

[commit-bot: I haz the power, 2013-02-01 21:22:49]

Failed to apply patch for remoting/host/win/remoting_core.manifest:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         remoting/host/win/remoting_core.manifest
  Copied chrome/app/chrome.dll.manifest ->
remoting/host/win/remoting_core.manifest
  patching file remoting/host/win/remoting_core.manifest
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
remoting/host/win/remoting_core.manifest.rej

Patch:   NR 
chrome/app/chrome.dll.manifest->remoting/host/win/remoting_core.manifest
Index: remoting/host/win/remoting_core.manifest
diff --git a/chrome/app/chrome.dll.manifest
b/remoting/host/win/remoting_core.manifest
similarity index 52%
copy from chrome/app/chrome.dll.manifest
copy to remoting/host/win/remoting_core.manifest
index
c2de75352d9e2170ea8af2331860747047b867c6..d3517547db9e2a107ebcdeceb0f292a1d1000fbe
100644
--- a/chrome/app/chrome.dll.manifest
+++ b/remoting/host/win/remoting_core.manifest
@@ -1,8 +1,8 @@
-<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
-  <dependency>
-    <dependentAssembly>
-      <assemblyIdentity type="Win32" name="Microsoft.Windows.Common-Controls"
version="6.0.0.0" processorArchitecture="X86" publicKeyToken="6595b64144ccf1df"
language="*"></assemblyIdentity>
-    </dependentAssembly>
-  </dependency>
-</assembly>
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+  <dependency>
+    <dependentAssembly>
+      <assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls"
version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df"
language="*" />
+    </dependentAssembly>
+  </dependency>
+</assembly>