chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc - Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: dcronin Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc ('k') | chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc b/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

index 645a3ff0ed9157228428422926e3288272813b9a..c387d8a3b89d2c7d468059856c6d6b6d21368b20 100644

--- a/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

+++ b/chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

@@ -13,14 +13,14 @@ namespace extensions {

class DefaultLocaleManifestTest : public ExtensionManifestTest {

virtual void SetUp() OVERRIDE {

ExtensionManifestTest::SetUp();

- ManifestHandler::Register(keys::kDefaultLocale,

- new DefaultLocaleHandler);

+ ManifestHandler::Register(extension_manifest_keys::kDefaultLocale,

+ make_linked_ptr(new DefaultLocaleHandler));

}

};

TEST_F(DefaultLocaleManifestTest, DefaultLocale) {

LoadAndExpectError("default_locale_invalid.json",

- errors::kInvalidDefaultLocale);

+ extension_manifest_errors::kInvalidDefaultLocale);

scoped_refptr<Extension> extension(

LoadAndExpectSuccess("default_locale_valid.json"));