Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/i18n/default_locale_handler.h" 5 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h" 6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_handler.h" 7 #include "chrome/common/extensions/manifest_handler.h"
8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace extensions { 11 namespace extensions {
12 12
13 class DefaultLocaleManifestTest : public ExtensionManifestTest { 13 class DefaultLocaleManifestTest : public ExtensionManifestTest {
14 virtual void SetUp() OVERRIDE { 14 virtual void SetUp() OVERRIDE {
15 ExtensionManifestTest::SetUp(); 15 ExtensionManifestTest::SetUp();
16 ManifestHandler::Register(keys::kDefaultLocale, 16 ManifestHandler::Register(extension_manifest_keys::kDefaultLocale,
17 new DefaultLocaleHandler); 17 make_linked_ptr(new DefaultLocaleHandler));
18 } 18 }
19 }; 19 };
20 20
21 TEST_F(DefaultLocaleManifestTest, DefaultLocale) { 21 TEST_F(DefaultLocaleManifestTest, DefaultLocale) {
22 LoadAndExpectError("default_locale_invalid.json", 22 LoadAndExpectError("default_locale_invalid.json",
23 errors::kInvalidDefaultLocale); 23 extension_manifest_errors::kInvalidDefaultLocale);
24 24
25 scoped_refptr<Extension> extension( 25 scoped_refptr<Extension> extension(
26 LoadAndExpectSuccess("default_locale_valid.json")); 26 LoadAndExpectSuccess("default_locale_valid.json"));
27 EXPECT_EQ("de-AT", LocaleInfo::GetDefaultLocale(extension)); 27 EXPECT_EQ("de-AT", LocaleInfo::GetDefaultLocale(extension));
28 } 28 }
29 29
30 } // namespace extensions 30 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698