Issue 12091099: Move focusSelectedItem to the end of showMenu() as it can cause the page to scroll prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12091099: Move focusSelectedItem to the end of showMenu() as it can cause the page to scroll prematurely. (Closed)

Created:
7 years, 10 months ago by aboxhall

Modified:
7 years, 10 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews), pam+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move focusSelectedItem to the end of showMenu() as it can cause the page to scroll prematurely. Also add outline: none to menu items in the drop-down menus on the history page, as the focus is indicated by the colour. BUG=172816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180059

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/resources/history/history.css	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/webui/resources/js/cr/ui/menu_button.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12091099/1

7 years, 10 months ago (2013-01-31 23:00:37 UTC) #4

Message was sent while issue was closed.

Change committed as 180059

Expand Messages | Collapse Messages