ui/webui/resources/js/cr/ui/menu_button.js - Issue 12091099: Move focusSelectedItem to the end of showMenu() as it can cause the page to scroll prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/menu_button.js

Issue 12091099: Move focusSelectedItem to the end of showMenu() as it can cause the page to scroll prematurely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/menu_button.js

diff --git a/ui/webui/resources/js/cr/ui/menu_button.js b/ui/webui/resources/js/cr/ui/menu_button.js

index bc86858ed1cefc7abddb849a4aeeebfb82e3ab92..0649f7d5020b2a1de10208df1879679979583790 100644

--- a/ui/webui/resources/js/cr/ui/menu_button.js

+++ b/ui/webui/resources/js/cr/ui/menu_button.js

@@ -162,8 +162,6 @@ cr.define('cr.ui', function() {

this.menu.hidden = false;

this.setAttribute('menu-shown', '');

- if (shouldSetFocus)

- this.menu.focusSelectedItem();

// When the menu is shown we steal all keyboard events.

var doc = this.ownerDocument;

@@ -174,6 +172,9 @@ cr.define('cr.ui', function() {

this.showingEvents_.add(win, 'resize', this);

this.showingEvents_.add(this.menu, 'activate', this);

this.positionMenu_();

+ if (shouldSetFocus)

+ this.menu.focusSelectedItem();

/**

« no previous file with comments | « chrome/browser/resources/history/history.css ('k') | no next file » | no next file with comments »