Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8438)

Unified Diff: chrome/browser/autofill/autofill_manager_delegate.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase harder Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager_delegate.h
diff --git a/chrome/browser/autofill/autofill_manager_delegate.h b/chrome/browser/autofill/autofill_manager_delegate.h
index 8f8115fcf1138217291c2c4e39d835e0618ff6d2..468fda9e1bee2e334af0afe55b9029cc272f9e70 100644
--- a/chrome/browser/autofill/autofill_manager_delegate.h
+++ b/chrome/browser/autofill/autofill_manager_delegate.h
@@ -23,6 +23,7 @@ class Rect;
class RectF;
}
+class AutofillMetrics;
class FormStructure;
class GURL;
class InfoBarService;
@@ -34,6 +35,13 @@ struct FormData;
namespace autofill {
+enum DialogType {
+ // Autofill dialog for the Autocheckout feature.
+ DIALOG_TYPE_AUTOCHECKOUT,
+ // Autofill dialog for the requestAutocomplete feature.
+ DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
+};
+
// A delegate interface that needs to be supplied to AutofillManager
// by the embedder.
//
@@ -93,6 +101,8 @@ class AutofillManagerDelegate {
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ DialogType dialog_type,
const base::Callback<void(const FormStructure*)>& callback) = 0;
// Called when the dialog for request autocomplete closes.
« no previous file with comments | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/autofill_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698