Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase harder Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/autofill_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 08303c2c52d6601203d8c394286b99f120554d42..5d91cdb55c3106dd4eaf1ada06f9e85450acd020 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -782,9 +782,10 @@ void AutofillManager::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ autofill::DialogType dialog_type,
const base::Callback<void(const FormStructure*)>& callback) {
manager_delegate_->ShowRequestAutocompleteDialog(
- form, source_url, ssl_status, callback);
+ form, source_url, ssl_status, *metric_logger_, dialog_type, callback);
}
void AutofillManager::RequestAutocompleteDialogClosed() {
@@ -835,7 +836,9 @@ void AutofillManager::OnRequestAutocomplete(
base::Callback<void(const FormStructure*)> callback =
base::Bind(&AutofillManager::ReturnAutocompleteData, this);
- ShowRequestAutocompleteDialog(form, frame_url, ssl_status, callback);
+ ShowRequestAutocompleteDialog(
+ form, frame_url, ssl_status,
+ autofill::DIALOG_TYPE_REQUEST_AUTOCOMPLETE, callback);
}
void AutofillManager::ReturnAutocompleteResult(
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/autofill_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698