Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the "autocomplete" prefix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
index 568aff948de8346e10a88df20e96825bc37473ed..748f7865edf43ebe7643c20b6042ad2308dcb1dc 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
@@ -11,19 +11,19 @@
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
-namespace autofill {
-class AutofillDialogControllerImpl;
-}
-
namespace content {
struct FrameNavigateParams;
struct LoadCommittedDetails;
class WebContents;
}
+namespace autofill {
+
+class AutofillDialogControllerImpl;
+
// Chrome implementation of AutofillManagerDelegate.
class TabAutofillManagerDelegate
- : public autofill::AutofillManagerDelegate,
+ : public AutofillManagerDelegate,
public content::WebContentsUserData<TabAutofillManagerDelegate>,
public content::WebContentsObserver {
public:
@@ -40,11 +40,13 @@ class TabAutofillManagerDelegate
virtual void ShowPasswordGenerationBubble(
const gfx::Rect& bounds,
const content::PasswordForm& form,
- autofill::PasswordGenerator* generator) OVERRIDE;
+ PasswordGenerator* generator) OVERRIDE;
virtual void ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ DialogRequester requester,
const base::Callback<void(const FormStructure*)>& callback) OVERRIDE;
virtual void RequestAutocompleteDialogClosed() OVERRIDE;
@@ -61,9 +63,11 @@ class TabAutofillManagerDelegate
void HideRequestAutocompleteDialog();
content::WebContents* const web_contents_;
- autofill::AutofillDialogControllerImpl* autofill_dialog_controller_; // weak.
+ AutofillDialogControllerImpl* autofill_dialog_controller_; // weak.
DISALLOW_COPY_AND_ASSIGN(TabAutofillManagerDelegate);
};
+} // namespace autofill
+
#endif // CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698