Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the "autocomplete" prefix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 117b7026975b2805802ab5ff1b94e1ba13346142..dcb06baebc9a24770f8728cf3687e59b38d18c47 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -21,7 +21,9 @@
#include "content/public/common/password_form.h"
#include "ui/gfx/rect.h"
-DEFINE_WEB_CONTENTS_USER_DATA_KEY(TabAutofillManagerDelegate);
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(autofill::TabAutofillManagerDelegate);
+
+namespace autofill {
TabAutofillManagerDelegate::TabAutofillManagerDelegate(
content::WebContents* web_contents)
@@ -89,6 +91,8 @@ void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ DialogRequester requester,
const base::Callback<void(const FormStructure*)>& callback) {
HideRequestAutocompleteDialog();
@@ -97,6 +101,8 @@ void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
form,
source_url,
ssl_status,
+ metric_logger,
+ requester,
callback);
autofill_dialog_controller_->Show();
}
@@ -118,3 +124,5 @@ void TabAutofillManagerDelegate::DidNavigateMainFrame(
// through the autocheckout flow (when the behavior is more fleshed out).
HideRequestAutocompleteDialog();
}
+
+} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698