Issue 12091075: Fix the issue introduced by hooking window.onbeforeunload in WebDialogView which breaks WebDialogUI…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12091075: Fix the issue introduced by hooking window.onbeforeunload in WebDialogView which breaks WebDialogUI… (Closed)

Created:
7 years, 10 months ago by jennyz

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the issue introduced by hooking window.onbeforeunload in WebDialogView which breaks the way WebDialogUI closing the dialog via "DialogClose" message from js. This is broken by my svn landed yesterday. https://src.chromium.org/viewvc/chrome?view=rev&revision=179427 Since we fire window.onbeforeunload event in WebDialogView, which makes dialog closing async now, we can't have WebDialogUI calls WebDialogDelegate::OnDialogClosed directly in response to "DialogClose" message. I added a new callback WebDialogDelegate::OnDialogCloseFromWebUI to support this case. While WebDialogDelegate is still used by WebDialogGtk, I provided a default WebDialogDelegate::OnDialogClosedFromWebUI implementation, which just calls WebDialogDelegate::OnDialogClosedFromWebUI, so that the gtk code flow should still work the same as before. BUG=172067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179771

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -3 lines)			Patch
M	ui/views/controls/webview/web_dialog_view.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/views/controls/webview/web_dialog_view.cc	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	ui/web_dialogs/web_dialog_delegate.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/web_dialogs/web_dialog_delegate.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/web_dialogs/web_dialog_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/12091075/1

7 years, 10 months ago (2013-01-30 23:03:16 UTC) #3

Message was sent while issue was closed.

Change committed as 179771

Expand Messages | Collapse Messages