ui/web_dialogs/web_dialog_ui.cc - Issue 12091075: Fix the issue introduced by hooking window.onbeforeunload in WebDialogView which breaks WebDialogUI…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/web_dialogs/web_dialog_ui.cc

Issue 12091075: Fix the issue introduced by hooking window.onbeforeunload in WebDialogView which breaks WebDialogUI… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/web_dialogs/web_dialog_ui.cc

diff --git a/ui/web_dialogs/web_dialog_ui.cc b/ui/web_dialogs/web_dialog_ui.cc

index 5f8709639f08f43bbbcee7ca413101f51683cd81..d4f0740f109aa90072441b50c49b2e6d6f278a4f 100644

--- a/ui/web_dialogs/web_dialog_ui.cc

+++ b/ui/web_dialogs/web_dialog_ui.cc

@@ -110,7 +110,7 @@ void WebDialogUI::OnDialogClosed(const ListValue* args) {

if (args && !args->empty() && !args->GetString(0, &json_retval))

NOTREACHED() << "Could not read JSON argument";

- delegate->OnDialogClosed(json_retval);

+ delegate->OnDialogCloseFromWebUI(json_retval);

}

« no previous file with comments | « ui/web_dialogs/web_dialog_delegate.cc ('k') | no next file » | no next file with comments »